Add support for Long operations inside predicates#139
Merged
CatarinaGamboa merged 2 commits intomainfrom Jan 30, 2026
Merged
Conversation
…ations inside predicates
rcosta358
approved these changes
Jan 30, 2026
| try { | ||
| return new LiteralInt(text); | ||
| } catch (NumberFormatException e) { | ||
| return new LiteralLong(text); |
Collaborator
There was a problem hiding this comment.
So we only convert a long to a LiteralLong if it overflows 32 bits, even if it was declared as a long, right?
Also, instead of using a try-catch here, we could do this:
String text = literalContext.INT().getText();
long value = Long.parseLong(text);
if (value >= Integer.MIN_VALUE && value <= Integer.MAX_VALUE) {
return new LiteralInt(text);
} else {
return new LiteralLong(text);
}Both are fine for me. Which one do you prefer?
Collaborator
Author
There was a problem hiding this comment.
to have literalContext.LONG() i needed to change the grammar in .g4 and i didn't want to 😅
We could not catch the exception its true, it probably is more readable so I'll change it! Athough we usually have more examples with ints but its fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we only tested with a small set of long operations, which did not include operations with Long values inside predicates or long values with L.
Example that would not be properly checked:
Now we can check this and see that the value is 3 and not 2 so an error.
This PR makes changes in:
LiteralLongAST node (we had LiteralInt, LiteralDouble, etc, no Long)LiteralLongthrough the full pipeline: visitor interface, Z3 translation (using mkInt for exact integersemantics), type inference, etc
long